Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engine_getPayloadV2 #3646

Closed
wants to merge 2 commits into from
Closed

Conversation

pawanjay176
Copy link
Member

Issue Addressed

ethereum/execution-apis#314

Proposed Changes

Add an engine_getPayloadV2 method that returns the block value along with the payload. Compare the block value with the bid received from the builder and pick the local execution block if it's of equal or higher value.

Additional Info

This PR assumes that the v2 method is available and queries the endpoint and falls back to the v1 method if the v2 method returns an error. Not certain how we should handle EL's not having the v2 method once it's rolled out in all ELs.
cc @realbigsean @paulhauner

@pawanjay176
Copy link
Member Author

@realbigsean tells me that there was an engine api versioning discussion that happened at devcon where there was a proposal to add a get_methods method to check versions. So we should probably wait for that to get in the specs before working on this.

@michaelsproul
Copy link
Member

I'm going to close this in favour of #3934 which is already merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants