Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider being less strict about chain spec in VC #2274

Closed
michaelsproul opened this issue Mar 20, 2021 · 2 comments
Closed

Consider being less strict about chain spec in VC #2274

michaelsproul opened this issue Mar 20, 2021 · 2 comments
Assignees
@michaelsproul
Labels
HTTP-API val-client Relates to the validator client binary

Comments

@michaelsproul
Copy link
Member

michaelsproul commented Mar 20, 2021 •
edited
Loading

Description

Currently a Lighthouse VC will reject any unknown fields included in a chain spec fetched from its BN. This has caused Lighthouse VCs to stop working with Teku BNs hosted by Infura, which is unfortunate.

See the corresponding issue on the Teku repo for more information: Consensys/teku#3749

Version

Lighthouse v1.2.1
@michaelsproul michaelsproul added val-client Relates to the validator client binary HTTP-API labels Mar 20, 2021
@michaelsproul michaelsproul mentioned this issue Mar 20, 2021
Closed
@paulhauner
Copy link
Member

This seems reasonable to me. Something irks me about silently accepting and then ignoring a configuration value, but it seems like it's better than the alternative.

@michaelsproul michaelsproul self-assigned this Mar 22, 2021
@michaelsproul michaelsproul mentioned this issue Mar 22, 2021
Closed
bors bot pushed a commit that referenced this issue Mar 26, 2021
@michaelsproul
VC: accept unknown fields in chain spec (#2277)
f9d60f5 
## Issue Addressed

Closes #2274

## Proposed Changes

* Modify the `YamlConfig` to collect unknown fields into an `extra_fields` map, instead of failing hard.
* Log a debug message if there are extra fields returned to the VC from one of its BNs.

This restores Lighthouse's compatibility with Teku beacon nodes (and therefore Infura)
@paulhauner
Copy link
Member

Resolved in #2277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsproul michaelsproul

Labels
HTTP-API val-client Relates to the validator client binary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @paulhauner