Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tokio-stream BroadcastStream #2189

Closed
paulhauner opened this issue Feb 10, 2021 · 0 comments
Closed

Use tokio-stream BroadcastStream #2189

paulhauner opened this issue Feb 10, 2021 · 0 comments
Assignees
@realbigsean
Labels
code-quality

Comments

@paulhauner
Copy link
Member

Description

#2172 by @realbigsean introduces the BroadcastStream which is copy-pasted from a tokio PR:

https://github.com/sigp/lighthouse/blob/d06dd14f549ba9e0315dd6413c45e797bcf357cd/beacon_node/http_api/src/broadcast_stream.rs

Once tokio-rs/tokio#3384 makes it into a release we should replace our copy-paste implementation with an import from tokio-stream.
@realbigsean realbigsean self-assigned this Feb 16, 2021
@realbigsean realbigsean mentioned this issue Feb 18, 2021
Closed
bors bot pushed a commit that referenced this issue Mar 1, 2021
@realbigsean
update tokio-stream to 0.1.3 and use BroadcastStream (#2212)
ed9b245 
## Issue Addressed

Resolves #2189 

## Proposed Changes

use tokio's `BroadcastStream`

## Additional Info

N/A


Co-authored-by: realbigsean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realbigsean realbigsean

Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@realbigsean @paulhauner