Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl Encode Decode for alloy_primitves::Bloom #30

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

yash-atreya
Copy link
Contributor

@yash-atreya yash-atreya commented Aug 22, 2024

Motivation

Missing Encode and Decode for alloy_primitives::Bloom, which is required here alloy-rs/alloy#1167.

Solution

implement Encode and Decode for Bloom

@yash-atreya yash-atreya changed the title feat: impl Encode Decode alloy_primitves::Bloom feat: impl Encode Decode for alloy_primitves::Bloom Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (c0476cb) to head (a0ae99e).
Report is 1 commits behind head on main.

Files Patch % Lines
ssz/src/encode/impls.rs 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   80.54%   80.16%   -0.39%     
==========================================
  Files          11       11              
  Lines         473      489      +16     
==========================================
+ Hits          381      392      +11     
- Misses         92       97       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelsproul
Copy link
Member

michaelsproul commented Aug 22, 2024

If you have time to add a quick roundtrip test that would be great. Otherwise I can jump on it tomorrow.

I think we can release this in 0.7.1, as it's not a breaking change?

@michaelsproul
Copy link
Member

I'm working on the test now.

@michaelsproul michaelsproul merged commit 0d60076 into sigp:main Aug 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants