perf: use NodeContact instead of Enr for sending talk_req() #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every time we were sending a talk request we were converting the
Enr
toNodeContact
. In doing this operation we callpublic_key()
or in other terms we are recovering the public key every time we send a talk request, in Portal we send all our messages over TalkRequests, currentlypublic_key()
is taking over 8.7% of the samples I get from running my benchmark ethereum/trin#1660, by reusing the NodeContact we can avoid repetitively recovering the public key every timeIn the benchmark I am sending 6.7GB of block history, so 8.7 percent is fairly significant
Notes & open questions
@jxs @AgeManning @ackintosh ping for review