fix: incorrect function call handling with session in non-REPL #777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is quite a fascinating project you've got here!
I have this niche use-case where I'm trying to use it on commandline by manually setting the session ID with the -s and --save-session argument, but found that the model's response does not get saved if it used a function call.
I believe this is due to you calling
exit_session
before processing the tool results here:aichat/src/main.rs
Lines 201 to 213 in 514a368
Moving the
start_directive
recursion before theexit_session
call seems to fix session handling and the save flag gets applied properly.I am 99% sure this doesn't break any other functionality, but I'm not very familiar with the codebase -- Please double-check this before considering a merge. Cheers.