Silverstripe 5 Incompatibilities

[dcentrica]

I've been using this module for a couple of months and I love it. Don't know why it's needed (its functionality should be in core), anyway.

Silverstripe 5.1
PHP 8.2 (strict mode)
Alpine Linux (Docker)

Basically, most of the methods declared in SearchFilterArrayList are incompatible with ArrayList, here's an example:

PHP Fatal error:  Declaration of Signify\SearchFilterArrayList\SearchFilterableArrayList::createSearchFilter(string $filter, $value) must be compatible with SilverStripe\ORM\ArrayList::createSearchFilter($filter, $value)

I've fixed a few, but each time I run dev/build there are more to fix. AFAICT, the fix is to add typehinting and return types where they occur in ArrayList.

[sig-steve]

Hi, I'm glad you like it, and I'll have a look at #5 shortly.

My understanding was that most, if not all, of the functionality of this module was going to be incorporated into Silverstripe CMS, probably in 5.1.0. See silverstripe/silverstripe-framework#10925; it has been merged, but I don't know whether it is included in 5.1.0 or not.

You may potentially not even need this module any more.

[sig-steve]

Ah, see this comment. @GuySartorelli wrote both this module, and the changes in silverstripe/silverstripe-framework#10925!

[GuySartorelli]

Yup! This functionality is available in core for silverstripe/framework 5.1.0 - so the module incompatibility is your cue to remove the module from your project as part of the upgrade to 5.1 and just use ArrayList directly 🥳

It's probably worth also checking the changelogs since there are some nuances to the implementation in core (e.g. default case sensitivity)

[dcentrica]

Cheers all!