Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud WAF Instance response computed properties #77

Conversation

grokify
Copy link
Contributor

@grokify grokify commented Sep 11, 2022

Enhancement to add Cloud WAF Instance read response computed properties for:

  1. cloudwaf_instance_id - This maps to the API response id property. The name has been modified for Terraform as id is not an allowed field name. The error is id is a reserved field name for a resource. See more here: id is now a reserved field name in Terraform russellcardullo/terraform-provider-pingdom#11 removed as duplicate to id value.
  2. deployment - This maps to the deployment API response property. While this is a JSON object in the API response, this is currently implemented as schema.TypeList with MaxItems set to 1 instead of being a schema.TypeMap due to a limitation in the Terraform Provider Go SDK which requires schema.TypeMap values to be strings. Using a TypeList wil result in deterministic 0-based hash indexes, so a property can be retrieved as deployment.0.dns_entry. This limitation conflicts with implementing deployment.egressIPs which is an array of object. See more here: Add support for maps with non-primitive types (rich / object map support) hashicorp/terraform-plugin-sdk#62

@grokify grokify changed the title enhance/cloudwaf_instance/add_response_properties Add Cloud WAF Instance response computed properties Sep 11, 2022
@jhanrahan-sigsci jhanrahan-sigsci merged commit 2893f87 into signalsciences:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants