Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate haproxy monitor #5543

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Deprecate haproxy monitor #5543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abc1c55
Deprecate haproxy monitor
atoulme Oct 23, 2024
6e7d696
Update internal/signalfx-agent/pkg/monitors/haproxy/monitor.go
atoulme Oct 23, 2024
96d2183
Update CHANGELOG.md
atoulme Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- (Splunk) Deprecate the collectd/nginx monitor. Please use the [nginx receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/nginxreceiver/) instead. ([#5537](https://github.com/signalfx/splunk-otel-collector/pull/5537))
- (Splunk) Deprecate the collectd/chrony monitor. Please use the [chronyreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/chronyreceiver) instead. ([#5536](https://github.com/signalfx/splunk-otel-collector/pull/5536))
- (Splunk) Deprecate the ecs-metadata monitor ([#5541](https://github.com/signalfx/splunk-otel-collector/pull/5541))
- (Splunk) Deprecate the haproxy monitor. Please use the [haproxyreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/haproxyreceiver) instead. ([#5543](https://github.com/signalfx/splunk-otel-collector/pull/5543))

### 🚀 New components 🚀

Expand Down
1 change: 1 addition & 0 deletions internal/signalfx-agent/pkg/monitors/haproxy/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
monitors:
- monitorType: haproxy
doc: |
**This monitor is deprecated and will be removed in a future release. Please use the haproxyreceiver instead.**
This monitor scrapes [HAProxy](http://www.haproxy.org/) statistics (i.e. metrics) from a configured
HTTP endpoint or UNIX socket. It requires HAProxy 1.8+ and supports scraping metrics for HAProxy running in
multi-process mode. In multi-process mode, HAProxy must be configured to enable stats on different URLs/socket
Expand Down
1 change: 1 addition & 0 deletions internal/signalfx-agent/pkg/monitors/haproxy/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ type proxies map[string]bool
// Config for this monitor
func (m *Monitor) Configure(conf *Config) (err error) {
m.logger = log.WithFields(log.Fields{"monitorType": monitorType, "monitorID": conf.MonitorID})
m.logger.Warn("[NOTICE] The haproxy monitor is deprecated and will be removed in a future release. Please use the haproxyreceiver instead.")
m.ctx, m.cancel = context.WithCancel(context.Background())
url, err := url.Parse(conf.ScrapeURL())
if err != nil {
Expand Down
Loading