Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate windowslegacy monitor #5518

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Deprecate windowslegacy monitor #5518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55a8337
Deprecate windowslegacy monitor
atoulme Oct 17, 2024
27cfe72
Update CHANGELOG.md
atoulme Oct 17, 2024
eabc242
Merge branch 'main' into deprecate_windowslegacy
atoulme Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- (Splunk) Deprecate the heroku observer. Use the [resource detection observer with heroku detector](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor#heroku) instead. ([#5496](https://github.com/signalfx/splunk-otel-collector/pull/5496))
- (Splunk) Deprecate mongodb atlas monitor. [Please use the mongodbatlasreceiver instead](https://docs.splunk.com/observability/en/gdi/opentelemetry/components/mongodb-atlas-receiver.html) ([#](https://github.com/signalfx/splunk-otel-collector/pull/))
- (Splunk) Deprecate python-monitor monitor ([#5501](https://github.com/signalfx/splunk-otel-collector/pull/5501))
- (Splunk) Deprecate windowslegacy monitor ([#5518](https://github.com/signalfx/splunk-otel-collector/pull/5518))
- (Splunk) Deprecate statsd monitor. Use the [statsd receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/statsdreceiver) instead. ([#5513](https://github.com/signalfx/splunk-otel-collector/pull/5513))

## v0.111.0
Expand Down
1 change: 1 addition & 0 deletions internal/signalfx-agent/pkg/monitors/windowslegacy/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
monitors:
- dimensions:
doc: |
**This monitor is deprecated and will be removed in a future release. Use the windowsperfcounters receiver instead.**
(Windows Only) This monitor reports metrics for Windows system Performance Counters.
The metric names are intended to match what was originally reported by
the SignalFx [PerfCounterReporter](https://github.com/signalfx/PerfCounterReporter)
Expand Down
1 change: 1 addition & 0 deletions internal/signalfx-agent/pkg/monitors/windowslegacy/windowslegacy_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ var logger = logrus.WithField("monitorType", monitorType)
// Configure the monitor and kick off metric syncing
func (m *Monitor) Configure(conf *Config) error {
m.logger = logger.WithField("monitorID", conf.MonitorID)
m.logger.Warn("[NOTICE] The windowslegacy monitor is deprecated and will be removed in a future release. Use the windowsperfcounters receiver instead.")
perfcounterConf := &winperfcounters.Config{
CountersRefreshInterval: conf.CountersRefreshInterval,
PrintValid: conf.PrintValid,
Expand Down
Loading