Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collectd/elasticsearch monitor #3997

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023

Description:

This PR removes the collectd/elasticsearch monitor in favor of the elasticsearch monitor.

As noted in the deprecation notice of the monitor:

    Monitors ElasticSearch instances. We strongly recommend using the
    [elasticsearch](./elasticsearch.md) monitor instead, as it will
    scale much better.

@atoulme atoulme requested review from a team as code owners December 1, 2023 05:20
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace w/ logged deprecation notice for at least a release

@rmfitzpatrick rmfitzpatrick dismissed their stale review December 7, 2023 14:39

warning exists

@atoulme atoulme merged commit 9e32197 into main Dec 8, 2023
130 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_collectd_elasticsearch branch December 8, 2023 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants