-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial discovery receiver skeleton #1830
Conversation
3dbd6b3
to
bdb0830
Compare
c8fd33c
to
632627d
Compare
} | ||
|
||
func (lr *LogRecord) validate() error { | ||
// TODO: supported severity text validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind if you want to use your own impl of LogRecord, but it might be easier to use plog.LogRecord if you want to access all the fields. For example, your LogRecord struct doesn't have SeverityText or SeverityNum. You would get that for free if you use plog.LogRecord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config log record is used to express the values that are desired in the actual plog.LogRecord
item that's going to be produced by the receiver. I don't know if it's possible to use a plog.LogRecord
in its place given the implementation is in "go.opentelemetry.io/collector/pdata/internal/data/protogen/logs/v1" and doesn't use mapstructure, but considering we only care about specific fields with more convenient accessors I don't think it's a concern.
Severity
becomes SeverityText
but since we may want to specify num as well I can update it.*
edit: updated
Changes look ok:
|
I don't plan on adding this as a component until its initial functionality has been merged (observer event emitting and metrics/statement evaluation are next PRs). There are also some required upstream PRs for this to be fully functional: open-telemetry/opentelemetry-collector-contrib#12801
This was the first PR and has landed: https://github.com/signalfx/splunk-otel-collector/blob/main/internal/receiver/discoveryreceiver/README.md |
|
fd7f2c8
to
fb532cf
Compare
fb532cf
to
6db85b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments!
529c59c
to
5edb839
Compare
5edb839
to
b955816
Compare
These changes introduce the initial Discovery receiver component methods and config validation (proposed readme: #1812).