Add preserveLeadingWhitespaces and preserveTrailingWhitespaces variables under logsCollection.containers in values.yaml #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les under logsCollection.containers in values.yaml
dmitryax
requested changes
Dec 13, 2024
Comment on lines
+624
to
+627
| # Whether to preserve leading whitespaces in logs. | ||
| preserveLeadingWhitespaces: false | ||
| # Whether to preserve trailing whitespaces in logs. | ||
| preserveTrailingWhitespaces: false |
There was a problem hiding this comment.
Why do we need extra parameters when these are already available with:
agent.config.receivers.filelog.preserve_leading_whitespaces
agent.config.receivers.filelog.preserve_trailing_whitespaces
Let's not extend the values.yaml interface when it is not necessary
There was a problem hiding this comment.
That's right, I missed the part with that configuration. I'll close this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Allow users to control whether filelog receiver should remove leading and trailing whitespaces from their logs. We noticed a case when one log message is spread across several logs and then joined using recombine operator, the default behaviour of filelog receiver (removing leading and trailing whitespaces) resulted in malformed combined log.
Testing: Manual testing
Documentation: