Skip to content

Commit

Permalink
[chore] ignore k8s.node.name when checking cluster metrics (#1622)
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme authored Jan 18, 2025
1 parent 48bff50 commit 8e185b8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion functional_tests/functional_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,7 @@ func testK8sClusterReceiverMetrics(t *testing.T) {
pmetrictest.IgnoreMetricAttributeValue("k8s.deployment.uid", metricNames...),
pmetrictest.IgnoreMetricAttributeValue("k8s.pod.uid", metricNames...),
pmetrictest.IgnoreMetricAttributeValue("k8s.pod.name", metricNames...),
pmetrictest.IgnoreMetricAttributeValue("k8s.node.name", metricNames...),
pmetrictest.IgnoreMetricAttributeValue("k8s.replicaset.uid", metricNames...),
pmetrictest.IgnoreMetricAttributeValue("k8s.replicaset.name", metricNames...),
pmetrictest.IgnoreMetricAttributeValue("k8s.namespace.uid", metricNames...),
Expand All @@ -860,7 +861,7 @@ func testK8sClusterReceiverMetrics(t *testing.T) {
pmetrictest.IgnoreMetricsOrder(),
pmetrictest.IgnoreScopeMetricsOrder(),
pmetrictest.IgnoreMetricDataPointsOrder(),
pmetrictest.IgnoreSubsequentDataPoints("k8s.container.ready", "k8s.container.restarts"),
pmetrictest.IgnoreSubsequentDataPoints("k8s.container.ready", "k8s.container.restarts", "k8s.pod.phase"),
)
if err != nil && os.Getenv("UPDATE_EXPECTED_RESULTS") == "true" {
writeNewExpectedMetricsResult(t, expectedMetricsFile, selectedMetrics)
Expand Down

0 comments on commit 8e185b8

Please sign in to comment.