Add timezone param to signalflow computation requests #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedoc2000
reviewed
Dec 22, 2020
signalfx/signalflow/__init__.py
Outdated
| @@ -33,12 +33,13 @@ def _get_params(self, **kwargs): | |||
|
|
|||
| def execute(self, program, start=None, stop=None, resolution=None, | |||
| max_delay=None, persistent=False, immediate=False, | |||
| disable_all_metric_publishes=None, withDerivedMetadata=None, | |||
| resolutionAdjustable=None): | |||
| timezone=None, disable_all_metric_publishes=None, | |||
There was a problem hiding this comment.
Please add the new parameter at the end of the current argument list so that people who don't use keyword arguments programs are not affect by this change
tedoc2000
suggested changes
Dec 22, 2020
|
done. sorry for the delay |
mpetazzoni
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #113
Note: completely untested. I lack the time to set up Python 2, and some of the tests seem to ask for a SFX token (which I can not provide).