Support timezone param for WebSocketTransport execute #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
This seems fine to me, but I'd like to see two things:
- Can you add a link to the docs for the timezone parameter? Is is just passed over the wire to the receiving side or is this actually configuring something in the transport itself?
- How would a user know what kind of value to pass in there? Do they pass in
PDTor do they pass inAmerica/Los_Angelesor would either work?
|
The timezone is passed over the wire to the receiving side as a query parameter. The docs link is https://dev.splunk.com/observability/docs/signalflow/#Supported-SignalFlow-time-zones The supported timezones are https://dev.splunk.com/observability/docs/time_zone |
|
Sorry what I meant was can you please add that in the javadocs so that a user can see it? 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SignaFlow client for java does not have a way to specify the timezone while the signalfx-python lib does. We would like to have similar capabilities.