Optionally pass trace context in http response via Server-Timing. #34
Conversation
If SIGNALFX_SERVER_TIMING_CONTEXT is turned on, pass trace context in traceparent form over a Server-Timing header. https://www.w3.org/TR/server-timing/ https://www.w3.org/TR/trace-context/#traceparent-header
| "github.com/signalfx/signalfx-go-tracing/ddtrace" | ||
| ) | ||
|
|
||
| func FormatAsTraceParent(context ddtrace.SpanContext) (string,bool) { |
There was a problem hiding this comment.
Do we expect to return invalid traceparent strings from this func? If not, may be get rid of the bool return val and just return a single string? Caller can then check for traceParent != "" instead of ok.
There was a problem hiding this comment.
The only case it would be "invalid" would be if the spanid/traceid are 0. I thought about using "" as the "not a real traceparent" but thought it wasn't very idiomatic go. I like your cleanup of the caller.
There was a problem hiding this comment.
Hmm. I think it actually might be idiomatic. I don't know. Generally, a second boolean return value is returned by operations that can't distinguish between a "not found" vs "found but was empty string" situations like a map lookup. Other cases generally tend to use a single return value.
|
LGTM. Added a couple of minor suggestions. |
Co-authored-by: Owais Lone <[email protected]>
If SIGNALFX_SERVER_TIMING_CONTEXT is turned on, pass trace context
in traceparent form over a Server-Timing header.
https://www.w3.org/TR/server-timing/
https://www.w3.org/TR/trace-context/#traceparent-header