This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Replace OpenTracing error logs with SignalFx tags #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
sfx-error-analyzer
branch
3 times, most recently
from
5cd66c6 to
b8e0413
Compare
owais
force-pushed
the
sfx-error-analyzer
branch
2 times, most recently
from
587ec06 to
34ac777
Compare
owais
force-pushed
the
sfx-error-analyzer
branch
17 times, most recently
from
e8d5e72 to
02fc10e
Compare
|
@rmfitzpatrick PTAL |
This PR changes how errors are recorded on spans. It uses the new SignalFx semantic convention and records the errors as attributes instead of logs. In addition to updating errors, also fixes multiple broken test and lint jobs in CircleCI.
owais
force-pushed
the
sfx-error-analyzer
branch
from
02fc10e to
615ba98
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace OpenTracing error logs with SignalFx tags
This PR changes how errors are recorded on spans. It uses the new
SignalFx semantic convention and records the errors as attributes
instead of logs.
In addition to updating errors, also fixes multiple broken test and lint
jobs in CircleCI.