This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Added SpanKind for gRPC Server and Client #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetazzoni
reviewed
Oct 18, 2019
mpetazzoni
assigned rmfitzpatrick, ghost
and keitwb and unassigned rmfitzpatrick and ghost
|
I removed SpanKind from Stream methods. SpanKind is only set in the interceptors. |
rmfitzpatrick
approved these changes
Oct 21, 2019
|
We haven't done a full pass to make the module supported but this change lgtm. |
ghost
closed this
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.