This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add leading zeros to the B3 propagation
x-b3-traceid
andx-b3-spanid
headers so that they are always 16 characters long as required by the specification.Benchmarks
Current implementation
Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^(BenchmarkToHex)$ github.com/signalfx/signalfx-go-tracing/ddtrace/tracer goos: linux goarch: amd64 pkg: github.com/signalfx/signalfx-go-tracing/ddtrace/tracer cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz BenchmarkToHex-16 21657834 55.59 ns/op 32 B/op 2 allocs/op PASS ok github.com/signalfx/signalfx-go-tracing/ddtrace/tracer 1.268s
Alternative implementation
Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^(BenchmarkToHex2)$ github.com/signalfx/signalfx-go-tracing/ddtrace/tracer goos: linux goarch: amd64 pkg: github.com/signalfx/signalfx-go-tracing/ddtrace/tracer cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz BenchmarkToHex2-16 8361780 142.4 ns/op 24 B/op 2 allocs/op PASS ok github.com/signalfx/signalfx-go-tracing/ddtrace/tracer 1.343s