Sarama improve async producer #120

owais · 2021-04-14T08:36:58Z

Fixed sarama instrumentation and introduced ContextExt interface

Sarama instrumentation was identifying spans with a non-unique and
uneligile key which caused a number of issues with span reporting as
some spans were not being finished. This commit replaces the said key
with the span ID.

This span ID is extracted from the kafka message headers and used to
identify any pending spans. This requires Kafka (not sarama) version
0.11.0 or newer which was released in 2017.

owais · 2021-04-14T08:50:13Z

Depends on #119

CHANGELOG.md

contrib/Shopify/sarama/sarama.go

contrib/Shopify/sarama/sarama_test.go

ddtrace/globaltracer.go

ddtrace/ddtrace.go

ddtrace/mocktracer/mockspan.go

ddtrace/tracer/tracer.go

CHANGELOG.md

pellared · 2021-04-14T13:41:20Z

nit: please update the PR description 😉

Sarama instrumentation was identifying spans with a non-unique and unelibale key which caused a number of issues with span reporting as some spans were not being finished. This commit replaces the said key with the span ID. This span ID is extracted from the kafka message headers and used to identify any pending spans. This requires Kafka (not sarama) version 0.11.0 or newer which was released in 2017.

pellared · 2021-04-14T14:08:03Z

ddtrace/tracer/tracer_test.go

+	c3 := &externalSpanContext{}
+	assert.Equal(t, SpanID(c3), uint64(0))
+	assert.Equal(t, TraceID(c3), uint64(0))
+


you can remove this empty line 😉

Co-authored-by: Robert Pająk <[email protected]>

pellared · 2021-04-14T14:10:55Z

ddtrace/tracer/tracer_test.go

+	c3 := &externalSpanContext{}
+	assert.Equal(t, SpanID(c3), uint64(0))
+	assert.Equal(t, TraceID(c3), uint64(0))
+


probably you could also add:

var c4 SpanContext assert.Equal(t, SpanID(c4), uint64(0)) assert.Equal(t, TraceID(c4), uint64(0))

also I like table-driven tests for tests like this https://blog.golang.org/subtests

I'm not gonna write a loop for 3 items 😆

owais requested a review from pellared April 14, 2021 08:46

owais force-pushed the sarama-improve-async-producer branch from 44af612 to 451ba5b Compare April 14, 2021 08:48

owais changed the base branch from main to fix-tracing-for-queues April 14, 2021 08:51

owais force-pushed the sarama-improve-async-producer branch from 451ba5b to efb1c31 Compare April 14, 2021 08:53

owais changed the base branch from fix-tracing-for-queues to main April 14, 2021 08:53

owais force-pushed the sarama-improve-async-producer branch 2 times, most recently from 057737e to e90170b Compare April 14, 2021 08:55