Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: update dependencies #354

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Node: update dependencies #354

merged 2 commits into from
Sep 21, 2021

Commits on Sep 21, 2021

  1. Make it clear to node-gyp which action arguments are paths 

    On Windows, node-gyp tries to be helpful by changing forward slashes
to backslashes and making paths relative to the source root rather
than the build directory, and indeed we rely on that. However, it has
to guess what's a path and what isn't. Previously, we worked around
that by manually stripping the prepended "..\", but the node-gyp
maintainers suggested a better workaround of using joined arguments
instead (`--foo=bar` instead of `--foo bar`).
    @jrose-signal
    jrose-signal committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ddce4ee View commit details
    Browse the repository at this point in the history

  2. Node: update dependencies 

    - Upgrade electron and typescript to match Desktop.
- Manually upgrade node-gyp and electron-mocha.
- Don't explicitly specify mocha; let electron-mocha choose it.
- Don't explicitly specify @types/node; let electron choose it.
- yarn upgrade
    @jrose-signal
    jrose-signal committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    b4aec0c View commit details
    Browse the repository at this point in the history