ffi: Expose CiphertextMessageType constants #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-signal
suggested changes
Oct 22, 2020
There was a problem hiding this comment.
These are wire level constants so I think the enum values should still be in the main rust code. If you look at the Rust tests, they bake in assumptions on what message types are being provided which isn't possible in a real client. [One goal of Ehren's is that it should eventually be possible to write a complete albeit primitive Signal client entirely in Rust - that isn't possible if these values aren't available to properly decode incoming messages]
Certainly good to expose the enum values into Swift
|
Oh, I didn't realize those type values were part of the wire protocol, rather than some other disambiguator. I'll put it back, then. |
jrose-signal
force-pushed
the
jrose/CiphertextMessageType
branch
from
0860733
to
b6caa7a
Compare
Also: - Expose them to Swift as well in a type-safe way - Verify that each constant matches the encoding used in rust/protocol/
We were only using it on enums, and unconditionally at that, so Rust's built-in numeric casts will have the same effect.
jrose-signal
force-pushed
the
jrose/CiphertextMessageType
branch
from
b6caa7a
to
3425025
Compare
jrose-signal
changed the title
jack-signal
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular Rust code doesn't need CiphertextMessageType because it can already match on CiphertextMessage. On the other hand, FFI code could really use named constants for the various message types.