Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jni: create_*_store functions can be removed #7

Closed
jack-signal opened this issue Oct 16, 2020 · 0 comments · Fixed by #12
Closed

jni: create_*_store functions can be removed #7

jack-signal opened this issue Oct 16, 2020 · 0 comments · Fixed by #12

Comments

@jack-signal
Copy link
Contributor

Instead move the runtime type check to the store new implementations
@jack-signal jack-signal mentioned this issue Oct 16, 2020
Merged
jrose-signal added a commit that referenced this issue Oct 16, 2020
@jrose-signal
Merge pull request #7 from signalapp/jrose/rustfmt-clippy
90cf751 
Add rustfmt and clippy to our PR tests (and fix issues)
jrose-signal added a commit that referenced this issue Oct 16, 2020
@jrose-signal
Merge pull request #7 from signalapp/jrose/c99-bool-again
a88e670 
Update for more 'bool' adoption in libsignal-ffi
jack-signal added a commit that referenced this issue Oct 19, 2020
@jack-signal
Merge pull request #7 from signalapp/jack/eckey-compare
54d81d6 
Add ECPublicKey comparison
jack-signal added a commit that referenced this issue Oct 19, 2020
@jack-signal
Remove some intermediate helper functions when creating JNI store obj…
5c4ee65 
…ects

Closes #7
@jack-signal jack-signal mentioned this issue Oct 19, 2020
Merged
@expiringplatform expiringplatform mentioned this issue Feb 23, 2023
Closed
johanvos pushed a commit to johanvos/libsignal-client that referenced this issue May 16, 2023
@tiainen
Merge pull request signalapp#7 from tiainen/grpc-proxy-respond-with-b…
2559c0c 
…ytes

gRPC response with bytes instead of string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some intermediate helper functions when creating JNI store objects signalapp/libsignal
1 participant
@jack-signal