-
-
Notifications
You must be signed in to change notification settings - Fork 421
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make it clear to node-gyp which action arguments are paths
On Windows, node-gyp tries to be helpful by changing forward slashes to backslashes and making paths relative to the source root rather than the build directory, and indeed we rely on that. However, it has to guess what's a path and what isn't. Previously, we worked around that by manually stripping the prepended "..\", but the node-gyp maintainers suggested a better workaround of using joined arguments instead (`--foo=bar` instead of `--foo bar`).
- Loading branch information
1 parent
0d5d700
commit ddce4ee
Showing
2 changed files
with
5 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters