Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Add coverage make target #1

Closed
wants to merge 1 commit into from
Closed

Add coverage make target #1

wants to merge 1 commit into from

Conversation

sjaeckel
Copy link
Contributor

Which runs the tests and creates code coverage using lcov

@sjaeckel
Add coverage make target
51c2e73 
Which runs the tests and creates code coverage using lcov
@moxie0
Copy link
Contributor

moxie0 commented Sep 24, 2015

Thanks for the PR @sjaeckel. Apologies but we just now got our CLA server setup for this repo, would you mind closing the PR and opening a new one?

@sjaeckel
Copy link
Contributor Author

Sure, NP

@sjaeckel sjaeckel closed this Sep 25, 2015
@sjaeckel sjaeckel reopened this Nov 16, 2015
@sjaeckel
Copy link
Contributor Author

Thanks.

@sjaeckel
Copy link
Contributor Author

Oh I just realized... the next time please don't edit someones' commit, but just add another commit with your changes :-)

@dkonigsberg
Copy link
Contributor

Was unsure how to proceed in that specific case of a relatively minor edit. Noted for future reference.

@moxie0
Copy link
Contributor

moxie0 commented Nov 18, 2015

@sjaeckel That's how we do it here. We want every commit in the repository to represent an ideal state, without any "in progress" or "transitional" commits. For larger changes we would get back to you and ask you to fix the commit, but we don't always have that much time and will just fix them up for smaller stuff. Sorry, that's how it's gotta be!

@signalapp signalapp locked and limited conversation to collaborators Nov 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjaeckel @moxie0 @dkonigsberg