Encapsulate the internal SQLite #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This fixes both signalapp/Signal-Desktop#4513 and signalapp/Signal-Desktop#5471 for us.
heftig
added a commit
to heftig/better-sqlite3
that referenced
this pull request
Aug 22, 2021
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp#3 that seems OK to upstream further.
JoshuaWise
pushed a commit
to WiseLibs/better-sqlite3
that referenced
this pull request
Aug 23, 2021
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp/better-sqlite3#3 that seems OK to upstream further.
Open
1 task
11 tasks
|
Sorry it took me a long time to get to this. Thanks so much for contributing it! |
|
hi! just a quick heads-up, signal-desktop v5.22.0 that was just released uses 32828e0 which is the |
|
@kpcyrd thanks for bringing it up. We try to keep dependencies unchanged between beta and prod releases where possible. It should go into the 5.23.x beta, though! |
Wambou
pushed a commit
to Wambou/better-sqlite3-multiple-ciphers
that referenced
this pull request
Nov 3, 2021
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp/better-sqlite3#3 that seems OK to upstream further.
adamharris1219
added a commit
to adamharris1219/Databaser-better-sqlite3
that referenced
this pull request
Nov 24, 2022
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp/better-sqlite3#3 that seems OK to upstream further.
webdev123123
added a commit
to webdev123123/better-sqlite3
that referenced
this pull request
Sep 17, 2023
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp/better-sqlite3#3 that seems OK to upstream further.
maplemike
pushed a commit
to GlobalTill/nsqlite3
that referenced
this pull request
Jan 25, 2024
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp/better-sqlite3#3 that seems OK to upstream further.
maplemike
added a commit
to GlobalTill/nsqlite3
that referenced
this pull request
Jan 25, 2024
Add linker flags to - prevent the dynamic linker from using an external SQLite for this library (`-Bsymbolic`) and - prevent the dynamic linker from using the internal SQLite for other libraries (`--exclude-libs ALL`). This is just a (conflict-free) cherry-pick of a Signal-specific fix in signalapp/better-sqlite3#3 that seems OK to upstream further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linker flags to
library (
-Bsymbolic) andlibraries (
--exclude-libs ALL).This fixes both signalapp/Signal-Desktop#4513
and signalapp/Signal-Desktop#5471 for us.