Fix extra tall error messages by rendering timestamp #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
fix-too-tall-error-messages#1266
branch
from
f4a2d42 to
48621fa
Compare
We were ocassionally seeing extra tall error messages. This is because, when appropriate, we were adding the space for a timestamp, but then never actually rendering the time stamp. So now: - Error Messages aren't rendered too-tall - Error Messages get a printed timestamp when appropriate // FREEBIE
michaelkirk
force-pushed
the
fix-too-tall-error-messages#1266
branch
from
48621fa to
9b36572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #1266
We were occasionally seeing extra tall error messages. This is because,
when appropriate, we were adding the space for a timestamp, but then
never actually rendering the timestamp.
So now:
// FREEBIE