Alternative solution for requiring direct taps for launching media vi…

[gluxon]

First time contributor checklist

• I have read the README and CONTRIBUTING documents
• I have signed the Contributor Licence Agreement

Contributor checklist

• I'm following the code, UI and style conventions
• My commits are rebased on the latest master branch
• My commits are in nice logical chunks
• My contribution is fully baked and is ready to be merged as is
• I have tested my contribution on these devices:
  • iPad Pro 9.7", iOS 9.3.3
• I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in my commit message

---

Description

Michael beat me to the solution for issue #1257. Although I wasn't able to get messageBubbleContainerView to properly instantiate, I think overriding the subclass's touch input method is a cleaner solution than the workaround in the message collection view controller. This is an alternative fix to the issue with images opening when clicking the white space horizontal to it, and allows info/error messages to be clickable.

I would not be offended if the other hack was used instead due to time constraints with the next Signal release. :)

[michaelkirk]

I do like this approach. I think there are a lot of opportunities like this to move polymorphic logic into subclasses, simplifying our big hairy view controller classes. Thanks - will merge after testing against latest master.

[michaelkirk]

Thanks @gluxon! 🎉