Missing nb_NO transl for placeholder text in new message

[byeskille]

• [ x ] I have searched open and closed issues for duplicates

---

Bug description

When viewing a chat dialogue with a contact the placeholder text in the composer for a new message is not translated to Norwegian.

The text will be shown in English as "New Message" even if the phone is set to Norwegian (Norsk bokmål). The rest of the app is translated correctly, and the placeholder text is changed to German if I change the phone to German.

I participated in the translations and it seems to be correct in Transifex, and even in this file in the repo:
nb_NO.lproj/Localizable.strings
on line 224
defined as MESSAGE_COMPOSEVIEW_TITLE

Steps to reproduce

• set iOS to Norwegian language (Norsk bokmål, nb_NO)
• open Signal for iOS
• open a chat dialogue with a contact
• confirm the placeholder text in the message composer is not translated and shows the English text "New Message"

Actual result: The placeholder text shows: New Message
Expected result: The placeholder text should have shown: Ny melding

Screenshots

Device info

Device: iPhone 6
iOS version: 9.3.2
Signal version: 2.3.1 beta

[byeskille]

Update:
It might be connected to this issue earlier experienced with Finnish: #784

[2-4601]

This is actually a duplicate of #1062.

[byeskille]

OK!

It seems some other Norwegian already have written a pull request with the necessary strings:
JSQMessagesViewController/pull/1564

So I guess Signal will get it when you update your version of the code?

But for some reason it is called nb.lproj/JSQMessages.strings and not nb_NO

Does this affect the usage in Signal?

[michaelkirk]

@byeskille - we are on our own fork of JSQMessageController, so it's not quite as simple as just pulling in the latest upstream code.

Closing as a dupe of #1062