Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSQMessagesViewController strings translatable #1062

Closed
2-4601 opened this issue Jan 26, 2016 · 1 comment · Fixed by #1255
Closed

Make JSQMessagesViewController strings translatable #1062

2-4601 opened this issue Jan 26, 2016 · 1 comment · Fixed by #1255
Milestone

Comments

@2-4601
Copy link
Contributor

2-4601 commented Jan 26, 2016

(I'm fusing #784 and #1033 into one issue.)

Three strings are not available for translation at Transifex because they rely on the strings of JSQMessagesViewController.

The strings are:

  • "Load Earlier Messages"
  • "Send"
  • "New Message"

re-animate f88daaf2-af09-11e5-814a-43cefffd5391

Currently affected languages (based on what's available at the upstream project):

  • az_AZ
  • bg_BG
  • bs
  • ca
  • cs
  • da
  • el_GR
  • es
  • fil
  • fi
  • hr
  • hu
  • lv
  • nb_NO
  • sl
  • sv_SE

Work around:
Submit a translation as a pull request to JSQMessagesViewController (see jessesquires/JSQMessagesViewController#237) and wait for it to get included in Signal iOS.

@michaelkirk
Copy link
Contributor

michaelkirk commented Jul 14, 2016

This will be edit: (partially) solved with #1255.

image
(It took me at least 2 minutes to remember how to switch back to english.)

Thanks for the upstream update @2-4601 👍

@michaelkirk michaelkirk modified the milestones: 2.3.6, On Roadmap, 2.4 Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants