Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes image messages don't expand message bubble to fit contents #1111

Closed
michaelkirk opened this issue Mar 13, 2016 · 2 comments · Fixed by #1255
Closed

Sometimes image messages don't expand message bubble to fit contents #1111

michaelkirk opened this issue Mar 13, 2016 · 2 comments · Fixed by #1255
Milestone
2.4

Comments

@michaelkirk
Copy link
Contributor

Haven't been able to reliably reproduce this but seen it several times.

After taking the images using camera (first one is fine, review the last two):

img_0351

After closing and restarting signal, I can see all image-containing bubbles correctly expanded to fit their image size.

img_0352
@2-4601
Copy link
Contributor

2-4601 commented Mar 13, 2016

Related #421?

@michaelkirk michaelkirk modified the milestone: 2.3 Apr 11, 2016
@michaelkirk michaelkirk mentioned this issue Jun 28, 2016
Merged
michaelkirk added a commit that referenced this issue Jun 28, 2016
@michaelkirk
Set explicit height for all media types. Audio is the only special case.
e42d640 
This might FIX #1111, but I think there are actually a handful of things
breaking our layout.

// FREEBIE
michaelkirk added a commit that referenced this issue Jun 28, 2016
@michaelkirk
Set explicit height for all media types. Audio is the only special ca…
b3bb4c7 
…se. (#1237)

This might FIX #1111, but I think there are actually a handful of things
breaking our layout.

// FREEBIE
@michaelkirk michaelkirk mentioned this issue Jul 13, 2016
Merged
@michaelkirk
Copy link
Contributor Author

This was not fixed by #1237. (But fix is forthcoming in #1255)

@michaelkirk michaelkirk reopened this Jul 13, 2016
@michaelkirk michaelkirk added this to the 2.3.6 milestone Jul 15, 2016
@michaelkirk michaelkirk modified the milestones: 2.3.6, 2.4 Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

Unfork/Update JSQMessagesViewController signalapp/Signal-iOS
2 participants
@2-4601 @michaelkirk