Make booleans stringable #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "unsure of how to jsonify object of type boolean", e.g., supportsSms: false
|
Yea...the whole type conversion stuff in this plugin is really killing me...mostly the fact that there are like 3 crypto libraries all which have different types they use for representation of binary blobs is not helping... |
|
The jsonify(undefined) thing I dont really like as its usually an indication of a bug that should be caught there instead of propagating further (esp if we're about to save undefined) |
|
We could just as easily intercept it one call up the stack, in doAjax. That actually makes more sense now that I think about it. |
For example, when requesting a verification code, there is no JSON data to send.
1 task
1 task
1 task
1 task
1 task
1 task
1 task
ghost
mentioned this pull request
1 task
1 task
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "unsure of how to jsonify object of type boolean",
e.g., supportsSms: false