Make errors more debuggable; capture correct stack, include name #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more errors like this in the logs!
```
INFO 2018-01-05T18:33:15.942Z Message.saveErrors: null Error
at file:///C:/Users/Test/AppData/Local/Programs/signal-desktop/resources/app.asar/js/libtextsecure.js:30:33
at file:///C:/Users/Test/AppData/Local/Programs/signal-desktop/resources/app.asar/js/libtextsecure.js:138:3
at file:///C:/Users/Test/AppData/Local/Programs/signal-desktop/resources/app.asar/js/libtextsecure.js:40718:3
```
It has no information in the title, and then the callstack points to
the `new Error()` line in the old `errors.js`.
This change will include the actual error name and message details in
the stack, and will include the original http error stack as well if
provided.
scottnonnenberg
added a commit
that referenced
this pull request
Jan 11, 2018
Update to Electron 1.7.10 (#1919) Fix issue where clicking Windows notification breaks window out of aero-snap location (#1918) Fix issue where old log data would persist in logs dir (#1945) Fix issue where disabled send field (in the middle of send) could be edited after click (#1937) Update strings (#1921) Dev: - Fix error to console when verifying contact in standalone mode (#1961) - Remove all built assets from repo (#1955) - Log out information from DOMException when import fails (#1923) - Log clearer messages regarding prekey/signed prekey fetches (#1961) - Make errors more debuggable; capture correct stack, include name (#1944) - Add eslint/mocha with code coverage for non-browser code (#1945) - Revamped github issue and pull request templates, updates to contributing.md/readme.md (#1955 and #1956) - Document building/testing releases in Contributing.md, thanks @veggiedefender (#1867) - Update a number of dependencies to the latest: builder, websocket, spellcheck (#1920)
scottnonnenberg
added a commit
that referenced
this pull request
Jan 23, 2018
_Note: This release is equivalent to [v1.2.0-beta.2](https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.2.0-beta.2). Listed below are the changes from the previous production release: [v1.1.0](https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.1.0)_ Update to Electron 1.7.10 (#1919) Fixed: clicking Windows notification would break window out of aero-snap location (#1918) Fixed: forwarded video would not play (#1977) Fixed: conversation was inaccessible if group member had invalid phone number (#1968) Fixed: powershell warning caused cert validation of downloaded update to fail on windows (#1976) Fixed: 'Missing signed prekey' errors after re-link (#1979) Fixed: data older than three days would persist in logs dir (#1945) Fixed: in the middle of send, disabled send field could be edited after click (#1937) Update strings (#1921) Add badge with unread count to the tray icon - thanks @m-pilia (#1934) _Note:_ to try this test feature out, use the `--use-tray-icon` and `--start-in-tray` command-line arguments Dev: - Additional logging for unexpected situations during sort of conversation list (#1969) - Dependency updates, fixes required for successful release (#1966 and #1976) - Log more info along with http errors (#1968) - Fix error to console when verifying contact in standalone mode (#1961) - Remove all built assets from repo (#1955) - Log out information from DOMException when import fails (#1923) - Log clearer messages regarding prekey/signed prekey fetches (#1961) - Make errors more debuggable; capture correct stack, include name (#1944) - Add eslint/mocha with code coverage for non-browser code (#1945) - Revamped github issue and pull request templates, updates to contributing.md/readme.md (#1955 and #1956) - Document building/testing releases in Contributing.md, thanks @veggiedefender (#1867) - Update a number of dependencies to the latest: builder, websocket, spellcheck (#1920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more errors like this in the logs!
It has no information in the title, and then the callstack points to the
new Error()line in the olderrors.js.This change will include the actual error name and message details in the stack, and will include the original http error stack as well if provided.