Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blurhash support #3819

Closed
1 task done
Xashyar opened this issue Dec 18, 2019 · 6 comments
Closed
1 task done

Add Blurhash support #3819

Xashyar opened this issue Dec 18, 2019 · 6 comments
Labels
Feature Request

Comments

@Xashyar
Copy link
Contributor

Xashyar commented Dec 18, 2019

  • I have searched open and closed issues for duplicates

Bug Description

Related: #2888
Desktop is the only client not to support blurred placeholders generated by Blurhash.

Actual Result: Unable to see Blurred placeholders before media download

Expected Result: Able to see Blurred placeholders before media download

Platform Info

Signal Version: 1.30.0-beta.1
@scottnonnenberg-signal scottnonnenberg-signal changed the title Blurhash support Add Blurhash support Dec 18, 2019
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 27, 2021
@Xashyar
Copy link
Contributor Author

Xashyar commented Sep 27, 2021

This is yet to be implemented.

@stale stale bot removed the stale label Sep 27, 2021
@indutny-signal
Copy link
Contributor

@Xashyar I believe we display blurhashes at least in some instances now. Could you elaborate which parts still miss it?

@Xashyar
Copy link
Contributor Author

Xashyar commented Sep 27, 2021

Hi @indutny-signal, you're right.

I had to recheck and for example, a Blurhash is shown while an image is being downloaded on Desktop.

Closing this for now.

@Xashyar Xashyar closed this as completed Sep 27, 2021
@indutny-signal
Copy link
Contributor

Yay, glad it works!

@indutny-signal
Copy link
Contributor

Thanks for trying, btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xashyar @scottnonnenberg-signal @indutny-signal