Unhandled Promise Rejection error if new release available but firewall blocks auto-update

[lacostenycoder]

• I have searched open and closed issues for duplicates

---

Bug Description

Unhandled Promise Rejection

App was open on MacOS 10.11.6 ( I know it's out of date ), app was idle in the background and I got an error alert notification see below.

Steps to Reproduce

1. Set to block MacOS from auto-updates using Little Snitch (firewall) because I'm a control freak.
2. Run Signal desktop app, and sit around waiting for an update to become available?
3. Copy the error message, and then select OK to close dialog, Signal app will auto shut down.
4. Restart the app, same error.
5. Update the app manually by downloading from https://signal.org/download/
6. Run new version with no errors.

Actual Result:

Get an error alert notification:

Unhandled Promise Rejection
Error: The resource could not be loaded because the App Transport Security policy requires the use of a secure connection.
    at MacUpdater.doDownloadUpdate (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/out/MacUpdater.js:167:7)
    at /Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:361:25
    at Generator.next (<anonymous>)
From previous event:
    at MacUpdater.downloadUpdate (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:539:7)
    at /Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:337:49
From previous event:
    at MacUpdater.doCheckForUpdates (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:502:7)
    at /Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:279:25
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at MacUpdater._checkForUpdates (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:433:7)
    at MacUpdater.checkForUpdates (/Applications/Signal.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:217:35)
    at Timeout.checkForUpdates [as _onTimeout] (/Applications/Signal.app/Contents/Resources/app.asar/app/auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

App won't run without this error until manually updating as described above

Expected Result:

Handle the error and notify the user that they need to update their version manually.

Screenshots

Platform Info

Signal Version: 1.19.0

Operating System:

MacOS 10.11.6

Linked Device Version:

Link to Debug Log

[devurandom]

@scottnonnenberg-signal mentions in #3056 that Signal Desktop v1.21.0 resolves this: #3056 (comment)

[scottnonnenberg-signal]

Yep, this is a duplicate of that bug. #3056

[reyo]

Just saying, same issue existed on Windows as well.

[reyo]

This is not fixed. I know two people who have gotten this also.

Unhandled Promise Rejection
Error: EPERM: operation not permitted, open 'C:\localpath\signal-desktop-updater\pending\temp-signal-desktop-win-1.21.1.exe'
    at ElectronHttpExecutor.download (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\electronHttpExecutor.ts:23:73)
    at Object.<anonymous> (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\NsisUpdater.ts:35:35)
From previous event:
    at Object.task (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\NsisUpdater.ts:31:11)
    at C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:610:25
From previous event:
    at NsisUpdater.executeDownload (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:545:68)
    at NsisUpdater.executeDownload (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\BaseUpdater.ts:27:18)
    at NsisUpdater.doDownloadUpdate (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\NsisUpdater.ts:27:17)
    at NsisUpdater.downloadUpdate (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:420:19)
    at C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:383:49
    at Generator.next (<anonymous>)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)
From previous event:
    at NsisUpdater.doCheckForUpdates (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:360:34)
    at NsisUpdater.checkForUpdates (C:\localpath\Programs\signal-desktop\resources\app.asar\node_modules\electron-updater\src\AppUpdater.ts:220:35)
    at Timeout.checkForUpdates [as _onTimeout] (C:\localpath\Programs\signal-desktop\resources\app.asar\app\auto_update.js:22:15)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

[scottnonnenberg-signal]

@reyo That's a separate error message, so this bug is tracking that issue: #3106

[spencerinaustin]

Unable to run Signal on my Mac now. How could this bug "Unhandled Promise Rejection" not be the highest priority?

[scottnonnenberg-signal]

@spencerinaustin Please enter a new bug, with complete information about your issue. This bug is closed because the original issue was resolved at some point. We generally open new bugs if it happens again, because there is often a slightly different cause or circumstance.