[Electron] Hangs at "loading", TypeError: conversation.save(...) is not a function

[chaoscommander]

• I have searched open and closed issues for duplicates

---

Bug description

Since I pulled the latest version from this repository, the application hangs on startup at the "loading" screen. I'm starting it from command line with npm start --production=true. The last stdout entry is as follows:

`{"name":"log","hostname":"redacted","pid":18031,"level":50,"msg":"Top-level unhandled error: TypeError: conversation.save(...).then is not a function
at file:///home/redacted/Programme/Signal-Desktop/js/models/messages.js:532:45`

at file:///home/redacted/Programme/Signal-Desktop/js/components.js:3230:33

at fire (file:///home/redacted/Programme/Signal-Desktop/js/components.js:3073:30)

at Object.fireWith [as resolveWith] (file:///home/redacted/Programme/Signal-Desktop/js/components.js:3185:7)

at deferred.(anonymous function) (file:///home/redacted/Programme/Signal-Desktop/js/components.js:3275:34)

at Object.options.success (file:///home/redacted/Programme/Signal-Desktop/js/components.js:22009:13)

at IDBTransaction.writeTransaction.oncomplete (file:///home/redacted/Programme/Signal-Desktop/js/components.js:21617:25)","time":"2018-01-13T17:01:08.828Z","v":0}`

Steps to reproduce

1. Install from git using bower and npm
2. Start from command line with npm start --production=true

Platform info

Signal version:
pulled from git today

Operating System:
Linux 4.12.12-gentoo #1 SMP PREEMPT Sat Nov 25 19:22:19 CET 2017 x86_64 Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz GenuineIntel GNU/Linux

Linked device version:

OnePlus One - LineageOS 14.1 (Android 7.1.2)

[chaoscommander]

Additional info: After letting it hang for a while I'm noticing the unread message count in the window title slowly (VERY slowly) counting up. Possibly it's not completely stuck, just very very slow. The above error message does look like something is wrong, though.

[scottnonnenberg]

Please send a log whenever makes sense. The log entries surrounding that error you included will be instructive in tracking down the core issue.

[scottnonnenberg]

Ah, I just figured out what it is. This pull request recently made us more resilient to phone numbers we believe are invalid: #1968

But now we have errors in other scenarios, as you've seen. It looks like you got a message from someone with an invalid phone number, so conversation.save() didn't return a Deferred. Please reach out to support, or to me directly, with that number and we can fix our phone number parsing.

[chaoscommander]

Hmm. Any idea how to find out whose message it might be that causes the error? To me, all my contacts have valid numbers and since Signal Desktop won't start properly I can't see on which of the thousands of messages in my history it is choking. At least not from stdout. Is there another log file? Sorry if I'm somehow too blind to find it. Am 16. Januar 2018 18:57:10 MEZ schrieb Scott Nonnenberg <[email protected]>:

…

Ah, I just figured out what it is. This pull request recently made us more resilient to phone numbers we believe are invalid: #1968 But now we have errors in other scenarios, as you've seen. It looks like you got a message from someone with an invalid phone number, so `conversation.save()` didn't return a Deferred. Please reach out to support, or to me directly, with that number and we can fix our phone number parsing. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #1970 (comment)

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

[scottnonnenberg]

In the log lines right above that error, you should see the last three digits of the problematic phone number, and that should help you track it down.

[chaoscommander]

I sent you an e-mail with the uncensored log and possibly offending phone numbers.

[peterpanondrugs]

My Signal for Windows got also stuck.
Is it safe to upload the log files without releasing personal information?
Let me know, then i will upload here the *.txt otherwise i need an email adres.
Thx

[scottnonnenberg-signal]

@peterpanondrugs You can find my email addresses on my github profile. But do know that we redact sensitive information like group and phone numbers from that log, so it should be safe to upload. Lastly, please enter a new bug, following the full issue template. Thanks!

[peterpanondrugs]

has it any relation to this #2196 ?! I posted my txt file there.
happy easter! :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to inactivity.