Message feed no longer stays scrolled to bottom

[mpcsh]

• I have searched open and closed issues for duplicates

---

Bug description

After the most recent update to the signal chrome app (the one that implemented that blue down arrow), when I receive a new message, the screen no longer auto-scrolls to the bottom.

Steps to reproduce

• launch the app
• have someone send you a message

Actual result: the app doesn't scroll to the bottom when a new message comes in
Expected result: the app does scroll to the bottom when a new message comes in

Screenshots

Platform info

Operating System: Arch Linux
Browser: Chromium 58.0.3029.110

Signal version: 0.40.0

Link to debug log

https://gist.github.com/0f690b27574255d17ab8ad6a19d83bd4

[miloofcroton]

I'm having this problem as well. Same comments from above apply to me.

Ubuntu Linux 17.04
Chrome Version 58.0.3029.110 (64-bit)

Signal version: 0.40.0

https://gist.github.com/anonymous/8383f25190f59374aa945f411ef8f9b3

[petcap]

I have the same issue, Signal no longer auto scrolls the message view on new incoming messages. I have to manually scroll down every time I receive or send a message. This only happens on one of my two computers. Both are running Signal 0.40.0, Chromium 58.0.3029.110 and Ubuntu 16.04.

The offending commit for the scrolling problem is bfdb825. The message view is only scrolled to the bottom if bottomOffset is equal to 0 (on line 43). On my laptop (which does not auto scroll), the bottomOffset has value 0.538330078125 which is a weird value for an offset.

I think this might be due to desktop scaling, my laptop has a high resolution screen so I scale the desktop up. I tried disabling scaling and the bug went away. For now, I have adjusted the if statement to floor the bottomOffset value.

Ping @scottnonnenberg

[deutrino]

This and #1206 are the latest in a bumper crop of bugs and regressions lately. I'm aware a single bug report isn't the greatest place to express this, but I wish the developers would focus on quality rather than features for a while. It's getting really aggravating.

Edit: I can confirm in Signal 0.40.0 on Chromium 58.0.3029.110 (Linux). And this is happening on a laptop with a 1366x768 screen, not scaled (at least not on purpose).

[liliakai]

Possibly fixed by changes in #1202.

[mpcsh]

@petcap I'm also on a HiDPI machine (Dell XPS 13 9360), I wonder if that's the cause

EDIT: ignore me, didn't see @gordon-morehouse's post

[scottnonnenberg]

Hey everyone, sorry you had to deal with this behavior over the weekend. We got the report of unexpected scroll behavior pretty quickly after releasing the update on Thursday evening. On Friday I submitted this now-merged PR: #1202

We'll soon have an update out with that fix. If you've got a second, we'd really appreciate your help verifying that those changes fix your issues. It's pretty simple to check out the repo and then load the unpacked extension into Chrome: https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md#installation

BTW, we really appreciate the additional detail from this thread, like the HighDPI settings and their effect on the problem. We don't have windows or linux HighDPI machines to test on, so your help is really important. Thanks!

@gordon-morehouse: Are there any other bugs of key importance for you that you're not seeing action on?

[deutrino]

Hi Scott, thanks so much for the response. I've checked out the repo and installed it in Chromium according to the linked instructions, but I can't get Signal to link to my phone, even after a reboot of the phone. I get "No device found" or occasionally "network error" even though the phone has Internet access (and in fact is on the same LAN as the Signal desktop instance).

Thanks also for asking, my pet issue is 1138. It's 100% reproducible for me and occurs nearly 100% of the time.

[scottnonnenberg]

@gordon-morehouse The dev application is connected to the staging server by default. To connect it to the production server and allow it to be paired with your phone, change https://textsecure-service-staging.whispersystems.org to https://textsecure-service-ca.whispersystems.org here: https://github.com/WhisperSystems/Signal-Desktop/blob/3dbb21c53c793bc2e3705941d61cce4c21e50b64/js/background.js#L40

I was just looking at #1138 this morning. It's a tough one! The right solution may be to add more logging and have you try the build. Will let you know.

[deutrino]

Okay, I tested it out. The dev build didn't sync down any old messages with my contacts, I don't know if that's normal or not. Anyway, this bug and #1206 do appear to be resolved! I am not on a HiDPI machine, however.

[petcap]

I got the updated version via the Chrome store, scrolling now works again!

[scottnonnenberg]

Glad to hear the new version fixed your issues! If anyone else continues to run into scrolling issues on 0.41.0, please open a new issue.