Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every Disappearing Message Sent on Signal iOS Received Twice on Signal Desktop on Mac #1138

Closed
1 task done
xanderdunn opened this issue Apr 29, 2017 · 20 comments · May be fixed by sudoWright/Signal-Desktop#8
Closed
1 task done

Comments

@xanderdunn
Copy link

  • I have searched open and closed issues for duplicates

Bug description

Steps to reproduce

  • Send a message on Signal iOS. Signal is not open on Desktop
  • Open Signal on Desktop

Actual result: Every message that was sent by myself on Signal iOS is received twice on Signal Desktop.
Expected result: Every message should be received only once on Desktop.

Screenshots

What I sent on Signal iOS:
fullsizerender

Signal Desktop receiving everything twice:
screen shot 2017-04-28 at 17 15 47

Platform info

iOS: 10.3.1
Mac Browser: Google Chrome 58.0.3029.81
Desktop Signal version: 0.37.0
iOS Signal Version: 2.10.1

Link to debug log

Desktop: https://gist.github.com/4daf45818c79d54d27ba77dfce37f8e6

@michaelkirk
Copy link
Contributor

michaelkirk commented Apr 29, 2017 via email

@xanderdunn
Copy link
Author

xanderdunn commented May 2, 2017

iOS Signal now version 2.11.1
Desktop Signal now version 0.38.1

Desktop: https://gist.github.com/92256a1c3453d7a897fcdc0ded0c161c
iOS: https://gist.github.com/4c462917b5e2135635ee674f22c323b8

Recent sent messages on Desktop:
screen shot 2017-05-02 at 12 44 16

Same on iOS:
img_3220

@liliakai
Copy link
Contributor

liliakai commented May 2, 2017

@xanderdunn What if you turn off disappearing messages?

@xanderdunn
Copy link
Author

@liliakai It looks like turning off disappearing messages made the messages appear only once on desktop. Turning it back on, it eventually came back.

screen shot 2017-05-02 at 14 36 04

I didn't try more than 3 test messages, so not very scientific.

@liliakai
Copy link
Contributor

liliakai commented May 2, 2017

Thanks. That's enough to hint that this is related to disappearing messages on the desktop side. Most likely a race between saving the message initially and then immediately updating it to start the countdown timer.

@liliakai liliakai changed the title Every Message Sent on Signal iOS Received Twice on Signal Desktop on Mac Every Disappearing Message Sent on Signal iOS Received Twice on Signal Desktop on Mac May 8, 2017
@Realiserad
Copy link

Realiserad commented May 8, 2017

Same as #1038?

@liliakai
Copy link
Contributor

liliakai commented May 8, 2017

Not the same.

@alajpie
Copy link

alajpie commented May 10, 2017

This also happens in messages sent from Signal on Android.

@deutrino
Copy link

And, it happens with me using Signal Android when I have Signal Desktop online - not just offline. Also, often one of the duplicates has a single "sent" checkmark, not the duplicate return receipt checkmark. I do wonder if #1038 is somehow related.

I'll try to do some rigorous testing in the next few days, this is happening almost constantly with me.

@Trolldemorted
Copy link
Contributor

@gordon-morehouse very unlikely.

#1038 is about hiding group messages that were duplicated because of network failures, you are experiencing something else (or your messages fail once every time).

@deutrino
Copy link

Okay, I got this to happen in a short span of time as shown in the screenshot from Desktop, and here are debug logs on both platforms. Relevant phone number ends in 005.

signal-dupes

Debug log from Desktop: https://gist.github.com/ec52423939aa52164ff55f4d3c40fe5a
Debug log from Android: https://gist.github.com/anonymous/54e0b78504981f5e0394816fbb16bc0c

@deutrino
Copy link

Do we know enough about this bug to remove the "iOS" and "Mac" bits from the title?

@arikroc
Copy link

arikroc commented Jun 6, 2017

I experience the same thing, as does someone else I talked with. Messages sent on Signal mobile from me appear duplicated when I use Signal desktop, though the recipient only sees them once.

@scottnonnenberg
Copy link
Contributor

I spent some time investigating this today, and I have a couple questions and a couple requests. First a couple questions for those of you experiencing this:

  • How many devices do you have on the receiving side, and how many on the sending side?
  • Does anyone experience this in a conversation without disappearing messages turned on?

Second, if you're willing, it would really help to know if these are truly different messages or a re-render problem. To determine if the application thinks about these as totally different messages, you can check these two places:

  • DOM: If you're running a debug version, you can right-click and 'Inspect' on the message. Check to see if the id of the <li> tag is the same for the duplicate messages. You can do the same thing if you're running the production release by going to chrome://extensions then clicking 'index.html' just right of 'Inspect Views.' Doing things this way, you'll need to manually dig down through the web page to find the messages.
  • In-memory: It would also help to see if there are duplicate messages in the the conversation's message list. To check that, you'll have to open the background page. Right-click and choose 'Inspect Background Page' or click background.htm (on chrome://extensions) if using the production build. Then enter window.ConversationController.get('+<phone number for the target conversation>'); into the console. You can then click into its messageCollection property, then its models property. The newest messages will be the last in the collection, with high index numbers. The data for each message is in its attributes property.

Thanks!

@lethargosapatheia
Copy link

I'm experiencing the same problem.
I use Signal on Android and when I exchange messages with someone who uses Signal on IOS and who also has the Desktop Application on a Mac OS, my messages (both sent and received) duplicate when I switch to my own Signal Desktop App, which is also on Mac OS Sierra (as a Chrome app, of course).

In the past I can confirm that some messages duplicated, but it happened quite rarely and I don't remember exactly the context. Sometimes it happened for several messages in a row, but then it all went back to normal.

For the second task I found it a little bit difficult to understand what you mean exactly. (I've downloaded the Signal Desktop app from here https://chrome.google.com/webstore/detail/signal-private-messenger/bikioccmkafdpakkkcpdbppfkghcmihk).
If I go to the extensions page in Chrome and then I right-click on Signal and click "Inspect", I get the html code on the whole Chrome extensions page (so it doesn't matter exactly where I click 'inspect', it's the same code). I'm not sure where to go to from there and how I could inspect the messages themselves.

@scottnonnenberg
Copy link
Contributor

@lethargosapatheia Thanks for jumping in and trying to gather that additional information for us. If you're not familiar with using the Chrome Desktop Tools, then it will be a little more challenging for you. The idea is to see where the duplication occurs - if you're inspecting the right file (index.html) you'll be able to highlight different tags and you'll see them show up on the page. When you find the items that represent the duplicated messages, we want to know if the ids are the same.

@jschneier
Copy link

I see the same issue. I have disappearing messages enabled with someone who uses Signal Android (and desktop as well) while I have Signal iOS + Signal Desktop on macOS. Only my (the iOS/macOS) user's messages get duplicated on desktop.

@jschneier
Copy link

Also the spinning bar at the top is constantly there which might just be a disappearing messages feature but looks like a syncing thing and appears buggy to me, there are already indicators that disappearing messages are enabled.

@jeremymasters
Copy link

When I experience this, I only have my phone and desktop linked. I had zero duplicated messages, then I turned on expiring messages from my android device. All messages sent from android were shown twice on the desktop. After sending 3 messages, I shut off disappearing messages on the android device and no more duplicate messages appearing on the desktop from android.

@scottnonnenberg
Copy link
Contributor

Signal Desktop 0.42.1, released to the Chrome Web Store today, has message de-duplication and a number of bug-fixes around disappearing messages. Please re-open this if you run into this behavior again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.