This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
fix scrolling crashes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to fix crashes like these:
Last Exception Backtrace:
0 CoreFoundation 0x185818d5c __exceptionPreprocess + 124 (NSException.m:166)
1 libobjc.A.dylib 0x184d2c528 objc_exception_throw + 56 (objc-exception.mm:521)
2 CoreFoundation 0x185818c30 +[NSException raise:format:arguments:] + 104 (NSException.m:132)
3 Foundation 0x1861a282c -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 112 (NSException.m:157)
4 UIKit 0x18f3a2814 __45-[UICollectionViewData validateLayoutInRect:]_block_invoke + 1500 (UICollectionViewData.m:447)
5 UIKit 0x18f3a1c90 -[UICollectionViewData validateLayoutInRect:] + 1500 (UICollectionViewData.m:0)
6 UIKit 0x18f3a10d0 -[UICollectionView layoutSubviews] + 260 (UICollectionView.m:3505)
7 UIKit 0x18f343f50 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1256 (UIView.m:14894)
8 QuartzCore 0x18994b670 -[CALayer layoutSublayers] + 184 (CALayer.mm:9200)
9 QuartzCore 0x18994f748 CA::Layer::layout_if_needed(CA::Transaction*) + 332 (CALayer.mm:9080)
10 UIKit 0x18f358dfc -[UIView(Hierarchy) layoutBelowIfNeeded] + 548 (UIView.m:10205)
11 UIKit 0x18fd990b4 -[UICollectionView setContentInset:] + 92 (UICollectionView.m:4794)
12 Signal 0x1032f1214 -[JSQMessagesViewController jsq_setCollectionViewInsetsTopValue:bottomValue:] + 88 (JSQMessagesViewController.m:1065)
13 Signal 0x1032f1190 -[JSQMessagesViewController jsq_updateCollectionViewInsets] + 204 (JSQMessagesViewController.m:1058)
14 Signal 0x1032e80ac -[JSQMessagesKeyboardController jsq_notifyKeyboardFrameNotificationForFrame:] + 120 (JSQMessagesKeyboardController.m:256)
15 UIKit 0x18f37b6c4 +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 620 (UIView.m:12174)
16 UIKit 0x18f391e6c +[UIView(UIViewAnimationWithBlocks) animateWithDuration:delay:options:animations:completion:] + 108 (UIView.m:12233)
17 Signal 0x1032e7f0c -[JSQMessagesKeyboardController jsq_handleKeyboardNotification:completion:] + 576 (JSQMessagesKeyboardController.m:233)
Don't touch the header zIndex at all, since we're not doing it consistently, and we don't need it modified anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @charlesmchen