Fix path handling for non-conforming datasets #81
+89
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces PR #79 because I accidentally created that one on the main branch of my fork.
Fixes #78. The matter was also recently dealt with in the SigMF specification repo in issue #321 and PR #322. In particular this PR addresses the issue raised by @lgoix in this comment.
The get_dataset_filename_from_metadata function returns the full file path for non-conforming datasets, not just the file name. Furthermore an unit test verifying this, plus a couple of typos described in the above issue fixed.