Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging and Test Improvements #22

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Packaging and Test Improvements #22

merged 6 commits into from
Sep 1, 2023

Conversation

Teque5
Copy link
Collaborator

@Teque5 Teque5 commented Sep 1, 2023 •
edited
Loading

  • package no longer creates a dozen random sigmf files when calling pytest
  • re-wrote Archive tests
  • will fix project description and insert README.md into our pypi page once I upload new version
  • incremented to v1.1.3

This was referenced Sep 1, 2023
Closed
Closed
gmabey
gmabey approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@gmabey gmabey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! I am curious why you seem to prefer double-quotes for strings over single quotes though.

sigmf/__init__.py
@@ -4,7 +4,7 @@
#
# SPDX-License-Identifier: LGPL-3.0-or-later

__version__ = '1.1.2'
__version__ = "1.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a double increment -- current version is 1.1.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed v1.1.2 to pypi yesterday.

tests/conftest.py Outdated Show resolved Hide resolved
@Teque5
Copy link
Collaborator Author

Teque5 commented Sep 1, 2023

Looks great overall! I am curious why you seem to prefer double-quotes for strings over single quotes though.

I actually don't, but instead of manually fixing things with flake8, I've been using black lately that just forces PEP8 (with double quotes). Also lately I've been coding in Rust and it's a good reminder to me that over there strings are "like this" and unicode single characters are '✪'.

@Teque5 Teque5 merged commit c5aa8f3 into main Sep 1, 2023
@Teque5 Teque5 deleted the feature/packaging-and-tests branch September 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmabey gmabey gmabey approved these changes

@jacobagilbert jacobagilbert Awaiting requested review from jacobagilbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teque5 @gmabey