Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pathlib Paths in addition to string paths #29

Closed
Teque5 opened this issue Oct 4, 2023 · 0 comments · Fixed by #34
Closed

Support Pathlib Paths in addition to string paths #29

Teque5 opened this issue Oct 4, 2023 · 0 comments · Fixed by #34
Labels
good first issue Good for newcomers

Comments

@Teque5
Copy link
Collaborator

Teque5 commented Oct 4, 2023 

from pathlib import Path
import sigmf
someplace = Path('/tmp')
sigmf.sigmffile.fromfile(someplace / 'whatever.sigmf')

AttributeError: 'PosixPath' object has no attribute 'lower'

Adding support for pathlib.PosixPath should be trivial.
@Teque5 Teque5 added the good first issue Good for newcomers label Oct 4, 2023
gregparkes pushed a commit to gregparkes/sigmf-python that referenced this issue Oct 26, 2023
Fixes issue sigmf#29
e40dbeb
@gregparkes gregparkes mentioned this issue Oct 26, 2023
Merged
Teque5 added a commit that referenced this issue Oct 27, 2023
@gregparkes @Teque5
Fixes issue #29 (#34)
046a439 
* Fixes issue #29, add test for string and Pathlib approaches

---------

Co-authored-by: Gregory Parkes <[email protected]>
Co-authored-by: Teque5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue #29 gregparkes/sigmf-python
1 participant
@Teque5