Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating the .sigmf archive format #44

Merged
merged 2 commits into from
May 18, 2017
Merged

Creating the .sigmf archive format #44

merged 2 commits into from
May 18, 2017

Conversation

bhilburn
Copy link
Contributor

@bhilburn bhilburn commented May 3, 2017

This creates a SigMF archive format, per the discussion in #15.

I fleshed out some ideas not previously discussed in #15, including combining multiple recordings into a single SigMF archive, so please review.

sigmf-spec.md Outdated

The metadata and dataset files that comprise a SigMF recording may be combined
into a file archive. Multiple SigMF recordings may be stored in a single
archive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss the idea of combining multiple recordings separately before putting it in the spec. It is a UI/API complication for anything that wants to read a SigMF recording because you then need more than a file-picker, and people will be tempted to create little languages for representing pathnames-plus-item-in-the-archive, which gets messy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - this is perhaps a little more complex than I first anticipated.

sigmf-spec.md Outdated
4. Each SigMF recording (comprised of a metadata file and a dataset file) MUST
be in separate directories.
5. The metadata and dataset files within a directory must have the same
filenames as the directory itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how point 3 is written negatively; it does not rule out that you could have two levels of directories (which is another complication), or using absolute paths (which would be bad).

I would suggest something to the effect of (I don't know what language POSIX uses to describe tar files):

  1. The archive MUST contain the following files: for each contained recording with some name given here metasyntactically as N, files named N (a directory), N/N.sigmf-meta, and N/N.sigmf-data.

  2. The archive MUST NOT contain any other files unless their pathnames begin with N/N. for some N which has .sigmf-meta and .sigmf-data files as described above.

(The item 4 is to allow for extensions without allowing for arbitrary junk. More minimally, we could say that for now no other files are allowed.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your suggestion, @kpreid. Nice work =)

@bhilburn
Copy link
Contributor Author

bhilburn commented May 11, 2017

Okay, PR updated with the comments from @kpreid, above.

Please review & comment!

@bhilburn bhilburn merged commit 922987b into master May 18, 2017
@bhilburn bhilburn deleted the archive-format branch May 19, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants