Support per_page search parameter #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the following search_* APIs to forward the `per_page` parameter. - search_code - search_commits - search_issues - search_repositories - search_users Test plan: updated unit tests to verify per_page parameter. Tested manually by query `search_issues(..., per_page=1)` and verified the results arrived one at a time in each http response. Closes sigmavirus24#1166
for more information, see https://pre-commit.ci
sigmavirus24
approved these changes
Nov 18, 2023
sigmavirus24
approved these changes
Nov 18, 2023
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following search_* APIs to forward the
per_pageparameter.Test plan: updated unit tests to verify per_page parameter. Tested manually by query
search_issues(..., per_page=1)and verified the results arrived one at a time in each http response.Closes #1166
Version Information
Python 3.10, using the latest version of github3.py (main branch)
Minimum Reproducible Example