-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_playlist: support audio playlists #696
base: main
Are you sure you want to change the base?
Conversation
f5c4dbd
to
f95a37c
Compare
f95a37c
to
7318787
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 95.07% 95.09% +0.01%
==========================================
Files 40 40
Lines 2357 2363 +6
==========================================
+ Hits 2241 2247 +6
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You're trying to support albums with Albums are meant to be retrieved with I don't see the value in supporting the same content with two different endpoints. |
I realize that right now it's maybe not convenient to call |
Please also following CONTRIBUTING.rst for more involved changes so wasted effort can be prevented: https://github.com/sigma67/ytmusicapi/blob/main/CONTRIBUTING.rst#pull-requests
|
I think it's useful for listing the audio counterparts, while >>> yt = YTMusic()
>>> playlist = "OLAK5uy_kzi7k-3sR60kgaRt8HpK2zBN6jlNOMoHw"
>>> [(s["videoId"], s["videoType"]) for s in yt.get_album(yt.get_album_browse_id(playlist))["tracks"]]
[('S9bCLPwzSC0', 'MUSIC_VIDEO_TYPE_OMV'), ('6CQ8FIRzjnk', 'MUSIC_VIDEO_TYPE_ATV'), ('sbCe_L_hXi0', 'MUSIC_VIDEO_TYPE_ATV')]
>>> [(s["videoId"], s["videoType"]) for s in yt.get_playlist(playlist)["tracks"]]
[('clxG52zpxIg', 'MUSIC_VIDEO_TYPE_ATV'), ('6CQ8FIRzjnk', 'MUSIC_VIDEO_TYPE_ATV'), ('sbCe_L_hXi0', 'MUSIC_VIDEO_TYPE_ATV')] |
No description provided.