Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_history #691

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Fix get_history #691

merged 3 commits into from
Dec 17, 2024

Conversation

sigma67
Copy link
Owner

@sigma67 sigma67 commented Dec 16, 2024

actual fix for #689

@sigma67
Copy link
Owner Author

sigma67 commented Dec 16, 2024

fyi @luisignaciocc your PR only circumvented the issue but did not fix it entirely.

The root cause is this new pin menu entry added by Google to history items.

This call was relying on the last entry in the list being the one with the feedbackToken to remove something from the history.

If you remove the menu parsing entirely this will not get parsed, breaking things like remove_history_items because there is no longer a way to get the required fefedbackToken for it.

@luisignaciocc
Copy link
Contributor

Oops, my bad! I didn’t have the full context about everything that was involved in that change.

@sigma67 sigma67 merged commit 7ef703c into main Dec 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants