get_playlist: join multiple title runs #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgvictorino
force-pushed
the
fix-playlist-title
branch
from
9ea6f79 to
f4ee2cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 94.88% 94.84% -0.05%
==========================================
Files 38 38
Lines 2289 2289
==========================================
- Hits 2172 2171 -1
- Misses 117 118 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sigma67
reviewed
Dec 17, 2024
tests/mixins/test_playlists.py
Outdated
| ( | ||
| "2024_03_get_playlist.json", | ||
| { | ||
| "id": "PLaZPMsuQNCsWn0iVMtGbaUXO6z-EdZaZm", |
There was a problem hiding this comment.
I appreciate the improved test fidelity. Could you move the expected output into files, just like the input? Maybe in a subdirectory next to the input files.
sgvictorino
force-pushed
the
fix-playlist-title
branch
from
a05abe8 to
fbbe5aa
Compare
|
@sgvictorino you may have forgotten to |
* Return complete titles when split on time-like strings:
```diff
>>> yt.get_playlist("PLaZPMsuQNCsWn0iVMtGbaUXO6z-EdZaZm")["title"]
-03 Jan
+03 Jan 12:09
```
* `test_get_playlist`: assert more props have the expected value/shape
sgvictorino
force-pushed
the
fix-playlist-title
branch
from
fbbe5aa to
21fe246
Compare
|
Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>>> yt.get_playlist("PLaZPMsuQNCsWn0iVMtGbaUXO6z-EdZaZm")["title"] -03 Jan +03 Jan 12:09test_get_playlist: assert more props have the expected value/shape