Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lower codecov severity to informational #276

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

michaeladler
Copy link
Member

Instead of failing the CI pipeline when code coverage slightly decreases, this change sets the codecov severity to informational. This allows the reviewer to assess the coverage changes and make the decision on whether to accept the changes, rather than automatically failing the build. This provides more flexibility and context for the coverage changes.

Description

Please provide a concise summary of the changes and their motivation.

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

Instead of failing the CI pipeline when code coverage slightly
decreases, this change sets the codecov severity to informational. This
allows the reviewer to assess the coverage changes and make the decision
on whether to accept the changes, rather than automatically failing the
build. This provides more flexibility and context for the coverage
changes.

Signed-off-by: Michael Adler <[email protected]>
@michaeladler michaeladler requested a review from stormc as a code owner February 3, 2025 08:47
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (6a9eeb2) to head (ee1e8f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   83.07%   82.96%   -0.11%     
==========================================
  Files          97       97              
  Lines        4885     4885              
==========================================
- Hits         4058     4053       -5     
- Misses        599      603       +4     
- Partials      228      229       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stormc stormc merged commit a9a70d3 into siemens:main Feb 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants