Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config): remove formatting rules #14

Closed

Conversation

Killusions
Copy link
Member

BREAKING CHANGE: eslint-config-typescript and eslint-config-angular no longer ship any formatting rules, please use prettier or set up formatting rules yourself

Removes the non-functional formatting rules

@Killusions
Copy link
Member Author

As discussed in #13

@Killusions
Copy link
Member Author

Unfortunately, eslint-config-prettier is still needed because of the formatting rules of the base eslint (not typescript):

ScreenFloat Shot of Arc at 17 Jan 2025 at 16_15_40

We could manually disable those, but we would have to keep up with it with updates (and eagerly because our peer dependencies are loose), so I suggest recommending it for now (and keeping it in the readme)

@spike-rabbit
Copy link
Member

Unfortunately, eslint-config-prettier is still needed because of the formatting rules of the base eslint (not typescript):
ScreenFloat Shot of Arc at 17 Jan 2025 at 16_15_40

We could manually disable those, but we would have to keep up with it with updates (and eagerly because our peer dependencies are loose), so I suggest recommending it for now (and keeping it in the readme)

We are manually enabling quote-props. I guess you can just remove this from our setting and it should work. Eslint is not having any formatting rules enabled in their config: https://github.com/eslint/eslint/blob/main/packages/js/src/configs/eslint-recommended.js

@Killusions Killusions force-pushed the fix/remove-formatting-rules branch from 4f39751 to 09ed232 Compare January 20, 2025 12:30
@Killusions
Copy link
Member Author

@spike-rabbit Removed

@spike-rabbit
Copy link
Member

since eslint-config-prettier is no longer needed please remove this from the examples and please add a note, that our linter does not do any formatting

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@Killusions Killusions force-pushed the fix/remove-formatting-rules branch from 09ed232 to 5ca6d24 Compare January 22, 2025 14:53
@Killusions
Copy link
Member Author

@spike-rabbit Done.

README.md Outdated Show resolved Hide resolved
@Killusions Killusions force-pushed the fix/remove-formatting-rules branch from 5ca6d24 to 5cfa901 Compare January 22, 2025 16:04
@Killusions Killusions force-pushed the fix/remove-formatting-rules branch from 5cfa901 to a9842d2 Compare January 22, 2025 16:11
Copy link
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kfenner kfenner changed the base branch from main to next January 22, 2025 17:35
@Killusions Killusions force-pushed the fix/remove-formatting-rules branch 2 times, most recently from 3362147 to 39b9cd1 Compare January 22, 2025 18:45
BREAKING CHANGE: `eslint-config-typescript` and `eslint-config-angular` no longer ship any formatting rules, please use prettier or set up formatting rules yourself.
@Killusions Killusions force-pushed the fix/remove-formatting-rules branch from 39b9cd1 to 99fe152 Compare January 22, 2025 18:49
@spike-rabbit
Copy link
Member

This is merged on next, but it seems like github does not recognize this as I rebased locally.
Next time we should push the updates here before pushing on next / main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants